Repository navigation
[API] Move KubeObject to api module - #4767
Merged
Merged
Conversation
mozesl-nokia
requested review from
efiacor,
kispaljr and
liamfallon
as code owners
September 22, 2026 13:50
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Assisted-by: Cursor:composer-2.5 Signed-off-by: Mózes László Máté
Assisted-by: Cursor:composer-2.5 Signed-off-by: Mózes László Máté
… possible Assisted-by: Cursor:grok-4.7 Signed-off-by: Mózes László Máté
Assisted-by: Cursor:grok-4.7 Signed-off-by: Mózes László Máté
Assisted-by: Cursor:grok-4.7 Signed-off-by: Mózes László Máté
Signed-off-by: Mózes László Máté
mozesl-nokia
force-pushed
the
kubeobject-move
branch
from
September 22, 2026 14:59
96184bf to
f55dd9f
Compare
liamfallon
reviewed
Sep 23, 2026
liamfallon
reviewed
Sep 23, 2026
liamfallon
reviewed
Sep 23, 2026
liamfallon
reviewed
Sep 23, 2026
liamfallon
approved these changes
Sep 23, 2026
liamfallon
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks @mozesl-nokia
efiacor
reviewed
Sep 23, 2026
efiacor
left a comment
Contributor
There was a problem hiding this comment.
I think we should add the api/kubeobject dir to the sonar.sources
https://github.com/kptdev/kpt/blob/main/sonar.properties#L10
I know it creates an onus on you to create some coverage for the node module but if it's going public then we prob need it.
…o sonar.properties Signed-off-by: Mózes László Máté
|
efiacor
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR moves the KubeObject,
kptfilekoand other related types and parsing methods into the kptapimodule from the SDK. With this move, we can break the dependency between the main kpt module and the SDK.This means the following import changes will be necessary (only for the moved types):
I've reorganised quite a bit of the files so that they are not as large as before, as well as fixing linting issues.
The fnresultv1.ResultItem type was parctically duplicated (once again) amongs the KubeObject types, this was deduplicated, meaning a breaking API change for the consumers of the SDK types. It should not affect yaml/json, only the go types.
There is this comment on
ResourceList:and I am fairly certain the deduplication did not break this, but we may want to check (if we still care about this, the comment is from 2022).
For reviewers: As this is a massive change wholesale, I suggest looking at the changes commit-by-commit to see what has actually changed besides just copy-pasting.
AI disclosure: