Repository navigation
Tag lister improvements (restructure files, pass TLS certificates) - #4636
Merged
Merged
Conversation
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Mózes László Máté
Signed-off-by: Mózes László Máté
mozesl-nokia
force-pushed
the
tag-lister-improv
branch
from
September 17, 2026 13:03
2aeee8c to
1d95779
Compare
mozesl-nokia
marked this pull request as ready for review
September 17, 2026 13:04
mozesl-nokia
requested review from
efiacor,
kispaljr and
liamfallon
as code owners
September 17, 2026 13:04
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The TLS option is discarded, so configured extra certificates never reach the registry client.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR restructures tag listers and adds support for supplying extra TLS certificates.
Changes:
- Extracts the registry-backed lister.
- Adds extra TLS certificate options.
- Adds lister tests.
File summaries
| File | Summary |
|---|---|
pkg/lib/runneroptions/runneroptions.go |
Adds extra TLS certificate configuration. |
pkg/fn/runtime/runner.go |
Configures the registry client and listers; the TLS option is currently discarded. |
pkg/fn/runtime/regclient_lister.go |
Defines the registry-backed tag lister. |
pkg/fn/runtime/local_lister.go |
Retains local tag-listing logic. |
pkg/fn/runtime/lister_test.go |
Tests lister helpers and parsing. |
Review details
- Files reviewed: 4/5 changed files
- Comments generated: 1
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
9 of 10 tasks
Signed-off-by: Mózes László Máté
|
liamfallon
approved these changes
Sep 23, 2026
efiacor
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR to add some library-oriented improvements to tag listers. Currently only includes a small restructure of the files and the ability to pass TLS files to the runner.
No AI was used in the creation of this PR.