Repository navigation
fix(windows): use isExecutable for icon and color lookup - #2448
Merged
Merged
Conversation
CatsDeservePets
marked this pull request as ready for review
March 21, 2026 03:08
CatsDeservePets
changed the title
isExecutable for icon and color lookup
This was referenced Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the way
lfhandles executable files underWindows.Previously,
isExecutablewas only used for completions. It is now also used for icon and colour parsing.This change also removes a useless
logstatement, seemingly left over from development, which could cause log files to grow excessively. In addition, executable extensions are now parsed once up front instead of being recalculated on every check.