Repository navigation
feat: add borderstyle option - #2445
Merged
Merged
Conversation
Collaborator
Author
|
Hello @joelim-work! What are your thoughts on this? |
joelim-work
reviewed
Mar 20, 2026
joelim-work
left a comment
Contributor
There was a problem hiding this comment.
My main concern with this exact implementation is that removing drawbox is a breaking change, and I expect there to be many users as well. Now you can no longer toggle borders using something like set drawbox!. I am probably fine with another enum string option like borderstyle or similar that takes effect only if drawbox is enabled, and perhaps it could be merged with roundbox too.
CatsDeservePets
marked this pull request as ready for review
March 20, 2026 14:35
Ranger like drawborders optionborderstyle option
joelim-work
approved these changes
Mar 21, 2026
joelim-work
left a comment
Contributor
There was a problem hiding this comment.
LGTM, I had a couple of very minor comments but they are very trivial. Free free to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set draw_borders separatorssetting #1438drawboxadditional options #1439This PR adds a new option
borderstyle. It extends the capabilities oflf'sdrawboxoption to allow forrangerlike border designs.The following values are allowed:
box(default),roundbox(replacesset roundbox),round,outline,roundoutlineandseparators.Previous Description
This PR is essentially a 1:1 implementation of
ranger'sdraw_bordersoption and should not be considered finale.From
ranger's man page:set draw_borders noneequalsset drawbox false/set nodrawboxset draw_borders bothequalsset drawbox true/set drawboxNote:
set draw_bordersequalsset drawbox false/set nodrawbox(rangerinterprets it as an empty string which is equal tonone)Due to the existing
drawboxoption being of type bool, extending it while maintaining backward compatibility would be awkward.Therefore, it was suggested to deprecate it in favour of a new enum option. However, this goes against
lfs philosophy and I considerdrawboxbeing a core feature oflf.