Repository navigation
feat(logger): ability to skip logs based on user-defined logic - #3593
Merged
Merged
Conversation
Contributor
Author
|
Is there anyone to review? |
|
I want to filter specific route, which contains param |
Member
|
@palvaneh Please help to rebase the master branch. I will take it after CI passing. |
appleboy
approved these changes
Feb 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3593 +/- ##
=======================================
Coverage 99.21% 99.21%
=======================================
Files 42 42
Lines 3175 3177 +2
=======================================
+ Hits 3150 3152 +2
Misses 17 17
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a backward-compatible update that let users skip logs based on customized logic.
Gin's
LoggerConfigonly allows configuringSkipPaths. It might not be enough when users need to skip logging based on different params like full path or status code.