Repository navigation
Fetaure/skip asset update 2 - #289
Merged
francoispluchino merged 2 commits intoSep 7, 2017
Merged
Conversation
Contributor
Author
|
I need to check the tests, I wonder why the coverage is down, because it's actually the same code?! |
Contributor
Author
|
related #251 |
Contributor
Author
|
@francoispluchino Sorry, I got it why coverage is down :) The used code is from composer. Any advice how to proceed with this. I think a PR on composer side might take some time. |
Member
|
@schmunk42 I'll take care of this PR this weekend. |
Contributor
Author
|
That would be awesome. We still might consider to mark this feature as experimental in 1.4.0. |
Member
|
@schmunk42 I will take care of your PR start next week. Is it possible to fix the tests before? |
Member
|
Thanks! |
francoispluchino
requested review from
francoispluchino
and removed request for
francoispluchino
September 7, 2017 08:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only drawback is, that the parent method is copied, because of one line.
But performance looks even better and issues with local paths and duplicates copies do not occur so far.