Skip to content
This repository was archived by the owner on Sep 3, 2026. It is now read-only.

Fixed schema syntax error - #3148

Merged
glye merged 1 commit into
7.5from
schema-syntax-error-defaul
May 19, 2022
Merged

glye merged 1 commit into
7.5from
schema-syntax-error-defaul

Conversation

@glye

@glye glye commented May 18, 2022

Copy link
Copy Markdown
Member
Question Answer
JIRA issue IBX-2914
Type bug
Target eZ Platform version v2.5
BC breaks no

Syntax error: DEFAUL -> DEFAULT

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@Steveb-p Steveb-p left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did it pass any tests? Is this file unused or something?

@Steveb-p
Steveb-p requested a review from a team May 18, 2022 07:42
@konradoboza
konradoboza requested a review from a team May 18, 2022 07:43
@mikadamczyk
mikadamczyk requested a review from a team May 18, 2022 07:58
@glye

glye commented May 18, 2022

Copy link
Copy Markdown
Member Author

How did it pass any tests? Is this file unused or something?

@Steveb-p Most likely. I found it when running tests manually, which I have to do because of reasons.

@glye
glye merged commit 5e7941c into 7.5 May 19, 2022
@glye
glye deleted the schema-syntax-error-defaul branch May 19, 2022 09:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

6 participants