Publish path is incorrectly constructed when AppendRuntimeIdentifierToOutputPath is set

[pranavkm]

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp3.1</TargetFramework>
    <RuntimeIdentifier>win-x64</RuntimeIdentifier>
    <AppendRuntimeIdentifierToOutputPath>false</AppendRuntimeIdentifierToOutputPath>
  </PropertyGroup>

  <Target Name="Say">
    <Message Text="OutputPath: $(OutputPath)" Importance="High" />
    <Message Text="PublishDir: $(PublishDir)" Importance="High" />
  </Target>

</Project>

Expected:

OutputPath: bin\Debug\netcoreapp3.1\
PublishDir: bin\Debug\netcoreapp3.1\publish\

Actual:

OutputPath: bin\Debug\netcoreapp3.1\
PublishDir: bin\Debug\netcoreapp3.1\win-x64\publish\

[wli3]

@pranavkm what is the impact of this bug? Is it blocking any feature development?

[pranavkm]

For Blazor WebAssembly projects, we plan on setting the browser-wasm RID in the SDK and for it to not appear in the project templates. Not having it appear in paths is part of it. We also noticed this during development, since the 14 additional characters started causing long path issues during local development.

[jeromelaban]

This issue is caused by this block:

sdk/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.BeforeCommon.targets

Lines 122 to 125 in 997376c

	<PublishDir Condition="'$(PublishDir)' == '' and
	'$(AppendRuntimeIdentifierToOutputPath)' != 'true' and
	'$(RuntimeIdentifier)' != '' and
	'$(_UsingDefaultRuntimeIdentifier)' != 'true'">$(OutputPath)$(RuntimeIdentifier)\$(PublishDirName)\</PublishDir>

Where:

sdk/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.BeforeCommon.targets

Line 123 in 997376c

'$(AppendRuntimeIdentifierToOutputPath)' != 'true' and

likely should compare equal to true.

Are there deployment tests for this kind of change that can be included in a PR ?

[VAllens]

Any progress ?????????????????????????????????????????????????????????????????????????