Repository navigation
[tests] Relax SpecialFolder write access checks Fixes #26225 - #26233
Conversation
Fixes #26225 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b9e1dd56-a66c-4e93-b2cc-32f5d7c85d4b
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b9e1dd56-a66c-4e93-b2cc-32f5d7c85d4b
There was a problem hiding this comment.
Pull request overview
This PR updates the LinkSdkRegressionTest.SpecialFolder test to avoid flaky write-access probes against privacy-protected special folders whose behavior varies with the host machine’s TCC permissions (macOS / Mac Catalyst).
Changes:
- Make
TestFolder’sreadOnlyexpectation nullable and skip the write probe when it’snull. - Skip write-access probing for macOS
Desktopand macOS/Mac CatalystMyDocuments, while preserving path and existence assertions. - Update the CI-tolerant helper to avoid write probing for macOS special folders whose accessibility can vary by host TCC state.
Use collision-safe temporary filenames, tolerate cleanup failures that can result from file-system permissions, and clarify that the TCC behavior is macOS-specific. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b9e1dd56-a66c-4e93-b2cc-32f5d7c85d4b
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #229fb58] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 203 tests passed 🎉 Tests counts✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
The
SpecialFoldertest writes temporary files to verify expected folder access, but access to macOS privacy-protected folders depends on the host's TCC state.Make the write-access expectation optional and skip that probe for protected folders on macOS and Mac Catalyst, while preserving path and existence assertions.
Fixes #26225
🤖 Pull request created by Copilot