Repository navigation
[net11.0] [dotnet] Remove workaround for dotnet/sdk#52480 - #25720
Conversation
The workaround overrode the _LinkReadyToRunMachO target to skip the built-in dylib creation. Now that dotnet/sdk#52480 has been merged, this is no longer needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
Removes the temporary MSBuild target override (_LinkReadyToRunMachO) that previously skipped the SDK’s built-in Mach-O dylib creation, now that dotnet/sdk#52480 has been merged and the workaround is no longer required.
Changes:
- Deleted the
_LinkReadyToRunMachOtarget override that emitted “Skipped built-in dylib creation”. - Leaves the remaining R2R Mach-O path fix/workarounds intact (e.g., runtime#79902).
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #889bbd6] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [PR Build #889bbd6] Build passed (Build macOS tests) ✅Pipeline on Agent |
🔥 [CI Build #889bbd6] Build failed (Build packages) 🔥Build failed for the job 'Build packages' (with job status 'Failed') Pipeline on Agent |
🚀 [CI Build #889bbd6] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 205 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
The
_LinkReadyToRunMachOtarget override was added as a temporary workaround to skip the built-in dylib creation until dotnet/sdk#52480 was merged.That PR has now been merged, so the workaround is no longer needed.
🤖 Pull request created by Copilot