Skip to content

[net11.0] [dotnet] Remove workaround for ResolveReadyToRunCompilers failing. Fixes #24495. - #25719

Merged
rolfbjarne merged 2 commits into
net11.0from
dev/rolf/remove-resolvereadytorun-workaround
Jun 22, 2026
Merged

[net11.0] [dotnet] Remove workaround for ResolveReadyToRunCompilers failing. Fixes #24495.#25719
rolfbjarne merged 2 commits into
net11.0from
dev/rolf/remove-resolvereadytorun-workaround

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Remove the custom ResolveReadyToRunCompilers target that was a workaround for dotnet/runtime#122985. The upstream issue has been fixed, so this workaround is no longer needed.

Fixes #24495

🤖 Pull request created by Copilot

@rolfbjarne
[dotnet] Remove workaround for ResolveReadyToRunCompilers failing. Fixes
c773624 
 #24495.

Remove the custom ResolveReadyToRunCompilers target that was a workaround
for dotnet/runtime#122985. The upstream issue
has been fixed, so this workaround is no longer needed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@rolfbjarne
rolfbjarne changed the base branch from main to net11.0 June 17, 2026 17:04
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@rolfbjarne
rolfbjarne marked this pull request as ready for review June 22, 2026 13:51
Copilot AI review requested due to automatic review settings June 22, 2026 13:51
@rolfbjarne
rolfbjarne enabled auto-merge (squash) June 22, 2026 13:51
Copilot AI reviewed Jun 22, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the repository’s custom ResolveReadyToRunCompilers MSBuild target override in dotnet/targets/Microsoft.Sdk.R2R.targets, which was previously kept as a workaround for dotnet/runtime issue #122985 and is now considered unnecessary due to the upstream fix.

Changes:

  • Deleted the local ResolveReadyToRunCompilers target workaround (including its placeholder Crossgen2Tool item for outer multi-RID builds).
  • Restored reliance on the .NET SDK’s built-in ResolveReadyToRunCompilers behavior for ReadyToRun publishing flows.

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

✅ [PR Build #8269e3f] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 8269e3ffe66e9c9214f0905dba23bfa8311efa8e [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

✅ [PR Build #8269e3f] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 8269e3ffe66e9c9214f0905dba23bfa8311efa8e [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 8269e3ffe66e9c9214f0905dba23bfa8311efa8e [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

✅ [PR Build #8269e3f] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 8269e3ffe66e9c9214f0905dba23bfa8311efa8e [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

🚀 [CI Build #8269e3f] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 205 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 9 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ linker (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 26 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 30 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 23 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 26 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: 8269e3ffe66e9c9214f0905dba23bfa8311efa8e [PR build]

@rolfbjarne
rolfbjarne merged commit 7ef3375 into net11.0 Jun 22, 2026
56 checks passed
@rolfbjarne
rolfbjarne deleted the dev/rolf/remove-resolvereadytorun-workaround branch June 22, 2026 18:08
@rolfbjarne rolfbjarne mentioned this pull request Jul 10, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@dalexsoto dalexsoto dalexsoto approved these changes

Assignees

No one assigned

Labels

copilot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove workaround for ResolveReadyToRunCompilers failing

4 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto