Skip to content

[LocalAuthenticationEmbeddedUI] Update bindings and xtro - #25119

Merged
dalexsoto merged 5 commits into
xcode26.5from
dev/alex/xc26.5-LocalAuthenticationEmbeddedUI
Apr 9, 2026
Merged

[LocalAuthenticationEmbeddedUI] Update bindings and xtro#25119
dalexsoto merged 5 commits into
xcode26.5from
dev/alex/xc26.5-LocalAuthenticationEmbeddedUI

Conversation

@dalexsoto

@dalexsoto dalexsoto commented Apr 9, 2026

Copy link
Copy Markdown
Member

No description provided.

@dalexsoto dalexsoto added this to the xcode26.5 milestone Apr 9, 2026
@dalexsoto
dalexsoto requested a review from rolfbjarne April 9, 2026 00:34
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@dalexsoto
dalexsoto enabled auto-merge (squash) April 9, 2026 01:22
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
rolfbjarne
rolfbjarne requested changes Apr 9, 2026
View reviewed changes
Comment thread tests/xtro-sharpie/api-annotations-dotnet/iOS-LocalAuthenticationEmbeddedUI.ignore Outdated
@@ -1,2 +1 @@
# unresponsive selector

@rolfbjarne rolfbjarne Apr 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*.ignore files with only comments can typically be deleted.

Comment thread tests/xtro-sharpie/api-annotations-dotnet/MacCatalyst-LocalAuthenticationEmbeddedUI.ignore Outdated
@@ -1 +1,2 @@
## No LocalAuthentication support for Catalyst

@rolfbjarne rolfbjarne Apr 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really a problem with this PR, but LocalAuthentication seems to work just fine on Mac Catalyst, since it's (almost) all bound now? I'm guessing this is an outdated comment and could thus be removed.

@dalexsoto
Address PR review feedback: clean up ignore files
044aa58 
- Delete iOS-LocalAuthenticationEmbeddedUI.ignore (comment-only)
- Remove outdated 'No LocalAuthentication support for Catalyst' comment

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dalexsoto
dalexsoto requested a review from rolfbjarne April 9, 2026 13:29
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

✅ [CI Build #b2d803b] Build passed (Build packages) ✅

Pipeline on Agent
Hash: b2d803b5572ae8614d20c20c60a0747bc5afd3c7 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

✅ [PR Build #b2d803b] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: b2d803b5572ae8614d20c20c60a0747bc5afd3c7 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: b2d803b5572ae8614d20c20c60a0747bc5afd3c7 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

✅ [CI Build #b2d803b] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: b2d803b5572ae8614d20c20c60a0747bc5afd3c7 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

🚀 [CI Build #b2d803b] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 158 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: b2d803b5572ae8614d20c20c60a0747bc5afd3c7 [PR build]

@dalexsoto
dalexsoto merged commit 523f834 into xcode26.5 Apr 9, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes

Assignees

No one assigned

Labels

copilot

Projects

None yet

Milestone

xcode26.5

Development

Successfully merging this pull request may close these issues.

3 participants

@dalexsoto @vs-mobiletools-engineering-service2 @rolfbjarne