[Intents] Add support for xcode 15. by mandel-macaque · Pull Request #19006 · dotnet/macios

mandel-macaque · 2023-09-12T19:01:47Z

No description provided.

github-actions · 2023-09-12T19:06:27Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

rolfbjarne · 2023-09-13T09:23:39Z

+		[NullAllowed]
+		[Watch (10, 0), NoMac, iOS (17, 0), MacCatalyst (17, 0)]
+		[Export ("numberOfAttachments", ArgumentSemantic.Copy)]
+		NSNumber NumberOfAttachments { get; }


github-actions · 2023-09-14T20:21:14Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2023-09-14T22:02:34Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-14T22:02:34Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: bed7bbbbb7268aedf858cfaeace14c580cce85fb [PR build]

vs-mobiletools-engineering-service2 · 2023-09-14T22:06:46Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-14T22:07:15Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-14T22:13:56Z

🔥 Failed to compare API and create generator diff 🔥

Failed to run apidiff

Pipeline on Agent
Hash: bed7bbbbb7268aedf858cfaeace14c580cce85fb [PR build]

vs-mobiletools-engineering-service2 · 2023-09-18T12:44:12Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 238 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 13 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 39 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: bed7bbbbb7268aedf858cfaeace14c580cce85fb [PR build]

tj-devel709 · 2023-09-19T15:33:18Z

+		[Abstract]
+		[Export ("handleEditMessage:completion:")]
+		void HandleEditMessage (INEditMessageIntent intent, Action completion);
+
+		[Export ("confirmEditMessage:completion:")]
+		void ConfirmEditMessage (INEditMessageIntent intent, Action completion);
+
+		[Export ("resolveEditedContentForEditMessage:withCompletion:")]
+		void ResolveEditedContent (INEditMessageIntent intent, Action completion);


Should these be async?

Ah I merged and your comments popped up. Async can't be applied in protocols

tj-devel709 · 2023-09-19T15:33:39Z

+	interface INUnsendMessagesIntentHandling {
+		[Abstract]
+		[Export ("handleUnsendMessages:completion:")]
+		void HandleUnsendMessages (INUnsendMessagesIntent intent, Action completion);
+
+		[Export ("confirmUnsendMessages:completion:")]
+		void ConfirmUnsendMessages (INUnsendMessagesIntent intent, Action completion);


Should these be async as well?

Same, Async can't go in protocols

[Intents] Add support for xcode 15.

d9a2e04

mandel-macaque requested a review from dalexsoto as a code owner September 12, 2023 19:01

Auto-format source code

98d533f

This comment has been minimized.

Sign in to view

haritha-mohan approved these changes Sep 12, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Sep 13, 2023

View reviewed changes

dalexsoto approved these changes Sep 14, 2023

View reviewed changes

mandel-macaque commented Sep 14, 2023

View reviewed changes

Comment thread src/intents.cs Outdated

mandel-macaque and others added 2 commits September 14, 2023 16:16

Update src/intents.cs

e87cdc6

Auto-format source code

bed7bbb

This comment has been minimized.

Sign in to view

tj-devel709 reviewed Sep 19, 2023

View reviewed changes

dalexsoto merged commit e95959a into dotnet:net8.0-xcode15 Sep 19, 2023

Conversation

mandel-macaque commented Sep 12, 2023

Uh oh!

github-actions Bot commented Sep 12, 2023

⚠️ Your code has been reformatted. ⚠️

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne Sep 13, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Sep 14, 2023

⚠️ Your code has been reformatted. ⚠️

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 14, 2023

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 14, 2023

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 14, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 14, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 14, 2023

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 18, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

tj-devel709 Sep 19, 2023

Choose a reason for hiding this comment

Uh oh!

dalexsoto Sep 19, 2023

Choose a reason for hiding this comment

Uh oh!

tj-devel709 Sep 19, 2023

Choose a reason for hiding this comment

Uh oh!

dalexsoto Sep 19, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants