[HealthKit] Add support for Xcode 15 beta 7 by haritha-mohan · Pull Request #18927 · dotnet/macios

haritha-mohan · 2023-09-05T15:06:35Z

Looking into a intro failure on iOS: Selector not found for HealthKit.HKHealthStore : workoutSessionMirroringStartHandler in System.Action`1[HealthKit.HKWorkoutSession] get_WorkoutSessionMirroringStartHandler() on HealthKit.HKHealthStore

Not ready to merge yet! Looking into a intro failure on iOS: Selector not found for HealthKit.HKHealthStore : workoutSessionMirroringStartHandler in System.Action`1[HealthKit.HKWorkoutSession] get_WorkoutSessionMirroringStartHandler() on HealthKit.HKHealthStore

github-actions · 2023-09-05T15:11:41Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

Co-authored-by: Manuel de la Pena

dalexsoto

👍

Co-authored-by: Alex Soto

tj-devel709

Looks good! I think you may need to add a few Async calls though!

Co-authored-by: Rolf Bjarne Kvinge

github-actions · 2023-09-08T12:51:45Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2023-09-08T14:11:03Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: ad9ac57d3e863d0df0a754f785fc85e314aaee18 [PR build]

vs-mobiletools-engineering-service2 · 2023-09-08T14:18:19Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-08T14:20:19Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-08T14:21:03Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-08T14:35:53Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
~~tvOS~~ (no change detected)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
~~tvOS~~: (empty diff detected)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: ad9ac57d3e863d0df0a754f785fc85e314aaee18 [PR build]

vs-mobiletools-engineering-service2 · 2023-09-08T16:26:49Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 237 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 13 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 38 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: ad9ac57d3e863d0df0a754f785fc85e314aaee18 [PR build]

haritha-mohan and others added 2 commits September 5, 2023 11:05

Auto-format source code

e605079

mandel-macaque added 2 commits September 5, 2023 11:16

Merge branch 'net8.0-xcode15' into net8.0-xcode15-healthkit

9048a16

Ignore selector that is not present on the sim.

f110664

mandel-macaque suggested changes Sep 5, 2023

View reviewed changes

Apply suggestions from code review

662e1d9

Co-authored-by: Manuel de la Pena

haritha-mohan marked this pull request as ready for review September 5, 2023 15:50

This comment has been minimized.

Sign in to view

dalexsoto requested changes Sep 5, 2023

View reviewed changes

Comment thread src/healthkit.cs Outdated

Comment thread src/healthkit.cs Outdated

Comment thread src/healthkit.cs Outdated

Comment thread src/healthkit.cs Outdated

This comment has been minimized.

Sign in to view

Apply suggestions from code review

49de871

Co-authored-by: Alex Soto

mandel-macaque approved these changes Sep 5, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Sep 6, 2023

View reviewed changes

Comment thread src/healthkit.cs Outdated

Comment thread src/healthkit.cs Outdated

tj-devel709 reviewed Sep 6, 2023

View reviewed changes

Comment thread src/healthkit.cs

tj-devel709 reviewed Sep 6, 2023

View reviewed changes

Comment thread src/healthkit.cs

tj-devel709 requested changes Sep 6, 2023

View reviewed changes

fix failing tests, addr review

73f9c4c

rolfbjarne requested changes Sep 7, 2023

View reviewed changes

Comment thread src/healthkit.cs Outdated

This comment has been minimized.

Sign in to view

haritha-mohan and others added 2 commits September 7, 2023 08:44

Update src/healthkit.cs

0e51bfb

Co-authored-by: Rolf Bjarne Kvinge

Merge branch 'net8.0-xcode15' into net8.0-xcode15-healthkit

fbc18ef

This comment has been minimized.

Sign in to view

tj-devel709 approved these changes Sep 7, 2023

View reviewed changes

dalexsoto approved these changes Sep 7, 2023

View reviewed changes

rolfbjarne approved these changes Sep 8, 2023

View reviewed changes

haritha-mohan and others added 2 commits September 8, 2023 08:46

fix watch sim?

d20605c

Auto-format source code

ad9ac57

haritha-mohan merged commit ae6ef4a into dotnet:net8.0-xcode15 Sep 11, 2023

haritha-mohan deleted the net8.0-xcode15-healthkit branch September 11, 2023 15:40

Conversation

haritha-mohan commented Sep 5, 2023

Uh oh!

github-actions Bot commented Sep 5, 2023

⚠️ Your code has been reformatted. ⚠️

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tj-devel709 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions Bot commented Sep 8, 2023

⚠️ Your code has been reformatted. ⚠️

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 8, 2023

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 8, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 8, 2023

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 8, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 8, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 8, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

Reviewers

Assignees