[CoreSpotlight] Add support for xcode 15. by mandel-macaque · Pull Request #18918 · dotnet/macios

mandel-macaque · 2023-09-03T17:43:38Z

No description provided.

github-actions · 2023-09-03T17:48:37Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

rolfbjarne · 2023-09-05T06:52:03Z


+		[iOS (9, 0), Mac (10, 11), MacCatalyst (13, 1), NoTV, NoWatch]
+		[Export ("initWithName:protectionClass:bundleIdentifier:options:")]
+		NativeHandle Constructor (string name, [NullAllowed] string protectionClass, string bundleIdentifier, nint options);


Looks like protectionClass can be a strongly typed enum:

https://developer.apple.com/documentation/corespotlight/cssearchableindex/4288306-initwithname?changes=latest_minor&language=objc

Agreed, let's add the enum

dalexsoto · 2023-09-05T21:07:56Z


+		[iOS (9, 0), Mac (10, 11), MacCatalyst (13, 1), NoTV, NoWatch]
+		[Export ("initWithName:protectionClass:bundleIdentifier:options:")]
+		NativeHandle Constructor (string name, [NullAllowed] string protectionClass, string bundleIdentifier, nint options);


Agreed, let's add the enum

Co-authored-by: Alex Soto

vs-mobiletools-engineering-service2 · 2023-09-11T17:06:06Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-11T17:10:15Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 2dd92c0da0628423573c1aa82e88214d9be29e9e [PR build]

vs-mobiletools-engineering-service2 · 2023-09-11T17:11:03Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-11T17:17:29Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-11T17:28:44Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 2dd92c0da0628423573c1aa82e88214d9be29e9e [PR build]

vs-mobiletools-engineering-service2 · 2023-09-11T20:02:25Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 237 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 13 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 38 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 2dd92c0da0628423573c1aa82e88214d9be29e9e [PR build]

[CoreSpotlight] Add support for xcode 15.

24fae4a

mandel-macaque requested a review from dalexsoto as a code owner September 3, 2023 17:43

Auto-format source code

3b09381

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Sep 5, 2023

View reviewed changes

dalexsoto requested changes Sep 5, 2023

View reviewed changes

mandel-macaque added 2 commits September 7, 2023 09:35

Merge branch 'net8.0-xcode15' into net8.0-xcode15-corespotlight

075d109

Address reviews.

6e651e6

dalexsoto approved these changes Sep 7, 2023

View reviewed changes

dalexsoto reviewed Sep 7, 2023

View reviewed changes

Comment thread src/corespotlight.cs Outdated

Update src/corespotlight.cs

7ffd25a

Co-authored-by: Alex Soto

rolfbjarne approved these changes Sep 7, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

Fix attrs.

6aff898

This comment has been minimized.

Sign in to view

Apple says is present, intro tells us the opposite.

2dd92c0

mandel-macaque merged commit 905cf5f into dotnet:net8.0-xcode15 Sep 12, 2023

mandel-macaque deleted the net8.0-xcode15-corespotlight branch September 12, 2023 17:45

mandel-macaque mentioned this pull request Sep 12, 2023

[Foundation] Add support for Xcode 15 beta 7. #19007

Merged

Conversation

mandel-macaque commented Sep 3, 2023

Uh oh!

github-actions Bot commented Sep 3, 2023

⚠️ Your code has been reformatted. ⚠️

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne Sep 5, 2023

Choose a reason for hiding this comment

Uh oh!

dalexsoto Sep 5, 2023

Choose a reason for hiding this comment

Uh oh!

dalexsoto Sep 5, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 11, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 11, 2023

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 11, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 11, 2023

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 11, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 11, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants