Skip to content

[registrar] Skip registering types removed in Xcode 15. - #18812

Merged
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:skip-registering-newsstandkit
Aug 25, 2023
Merged

[registrar] Skip registering types removed in Xcode 15.#18812
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:skip-registering-newsstandkit

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Aug 24, 2023

Copy link
Copy Markdown
Member

Apple completely removed the NewsstandKit framework and the
PKDisbursementAuthorizationController[Delegate] types in Xode 15, so let's not
generate any corresponding code in the static registrar.

This effectively adds basic support for using Xcode 15 with .NET 7 (take 2).

@rolfbjarne
[release/7.0.3xx] [registrar] Skip registering types removed in Xcode…
0d9e60b 
… 15.

Apple completely removed the NewsstandKit framework and the
PKDisbursementAuthorizationController[Delegate] types in Xode 15, so let's not
generate any corresponding code in the static registrar.

This effectively adds basic support for using Xcode 15 with .NET 7 (take 2).
@rolfbjarne rolfbjarne changed the title [release/7.0.3xx] [registrar] Skip registering types removed in Xcode 15. [registrar] Skip registering types removed in Xcode 15. Aug 24, 2023
@rolfbjarne rolfbjarne mentioned this pull request Aug 24, 2023
Merged
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Aug 24, 2023

Copy link
Copy Markdown
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 0d9e60b0852b48f96648e5121b6ddfb991630f13 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Aug 24, 2023

Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@dalexsoto

dalexsoto commented Aug 24, 2023

Copy link
Copy Markdown
Member

/sudo backport xcode14.3

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Aug 24, 2023

Copy link
Copy Markdown
Collaborator

Backport Job to branch xcode14.3 Created! The magic is happening here

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Aug 24, 2023

Copy link
Copy Markdown
Collaborator

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8304044 for more details.

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Aug 24, 2023

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 0d9e60b0852b48f96648e5121b6ddfb991630f13 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Aug 24, 2023

Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Aug 24, 2023

Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 35 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 0d9e60b0852b48f96648e5121b6ddfb991630f13 [PR build]

rolfbjarne added a commit that referenced this pull request Aug 25, 2023
@rolfbjarne
[release/7.0.3xx] [registrar] Skip registering types removed in Xcode…
c70a2f5 
… 15. (#18811)

Apple completely removed the NewsstandKit framework and the
PKDisbursementAuthorizationController[Delegate] types in Xode 15, so
let's not generate any corresponding code in the static registrar.

This effectively adds basic support for using Xcode 15 with .NET 7 (take
2).

Backport of #18812.
@rolfbjarne
rolfbjarne merged commit 2e7846d into dotnet:main Aug 25, 2023
@rolfbjarne
rolfbjarne deleted the skip-registering-newsstandkit branch August 25, 2023 05:42
@rolfbjarne

rolfbjarne commented Aug 25, 2023

Copy link
Copy Markdown
Member Author

/sudo backport release/8.0.1xx-rc1

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator

Backport Job to branch release/8.0.1xx-rc1 Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8308495 for more details.

dalexsoto pushed a commit that referenced this pull request Aug 26, 2023
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/8.0.1xx-rc1] [registrar] Skip registering types removed in X…
8cdd132 
…code 15. (#18822)

Apple completely removed the NewsstandKit framework and the
PKDisbursementAuthorizationController[Delegate] types in Xode 15, so
let's not
generate any corresponding code in the static registrar.

This effectively adds basic support for using Xcode 15 with .NET 7 (take
2).


Backport of #18812

Co-authored-by: Rolf Bjarne Kvinge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes
+1 more reviewer
@haritha-mohan haritha-mohan haritha-mohan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @haritha-mohan