[Code Style] Add some extra style checks focused on nullability. by mandel-macaque · Pull Request #17831 · dotnet/macios

mandel-macaque · 2023-03-17T02:03:14Z

Added the following new checks:

// dotnet_style_coalesce_expression = true
var v = x ?? y;

// dotnet_style_coalesce_expression = false
var v = x != null ? x : y; // or
var v = x == null ? y : x;

// dotnet_style_null_propagation = true
var v = o?.ToString();

// dotnet_style_null_propagation = false
var v = o == null ? null : o.ToString(); // or
var v = o != null ? o.String() : null;

// dotnet_style_prefer_is_null_check_over_reference_equality_method = true
if (value is null)
    return;

// dotnet_style_prefer_is_null_check_over_reference_equality_method = false
if (object.ReferenceEquals(value, null))
    return;

// dotnet_style_prefer_is_null_check_over_reference_equality_method = false
if ((object)o == null)
    return;

Added the following new checks: ```csharp // dotnet_style_coalesce_expression = true var v = x ?? y; // dotnet_style_coalesce_expression = false var v = x != null ? x : y; // or var v = x == null ? y : x; ``` ```csharp // dotnet_style_null_propagation = true var v = o?.ToString(); // dotnet_style_null_propagation = false var v = o == null ? null : o.ToString(); // or var v = o != null ? o.String() : null; ``` ```csharp // dotnet_style_prefer_is_null_check_over_reference_equality_method = true if (value is null) return; // dotnet_style_prefer_is_null_check_over_reference_equality_method = false if (object.ReferenceEquals(value, null)) return; // dotnet_style_prefer_is_null_check_over_reference_equality_method = false if ((object)o == null) return; ```

mandel-macaque · 2023-03-17T02:03:30Z

the format action should do its magic.

mandel-macaque · 2023-03-17T04:20:55Z

/azp run

azure-pipelines · 2023-03-17T04:21:17Z

Azure Pipelines successfully started running 1 pipeline(s).

rolfbjarne

I think you need to set the style like this:

dotnet_style_coalesce_expression = true

because autoformat didn't do anything.

tj-devel709

Interesting!

vs-mobiletools-engineering-service2 · 2023-06-21T16:35:22Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 4040fe9f1c2759c9d762b4cdb188004e4b1ce022 [PR build]

vs-mobiletools-engineering-service2 · 2023-06-21T16:44:58Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-06-21T17:06:29Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 4040fe9f1c2759c9d762b4cdb188004e4b1ce022 [PR build]

vs-mobiletools-engineering-service2 · 2023-06-21T17:06:58Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-06-21T17:10:50Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-06-21T20:06:44Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 35 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 4040fe9f1c2759c9d762b4cdb188004e4b1ce022 [PR build]

) Added the following new checks: ```csharp // dotnet_style_coalesce_expression = true var v = x ?? y; // dotnet_style_coalesce_expression = false var v = x != null ? x : y; // or var v = x == null ? y : x; ``` ```csharp // dotnet_style_null_propagation = true var v = o?.ToString(); // dotnet_style_null_propagation = false var v = o == null ? null : o.ToString(); // or var v = o != null ? o.String() : null; ``` ```csharp // dotnet_style_prefer_is_null_check_over_reference_equality_method = true if (value is null) return; // dotnet_style_prefer_is_null_check_over_reference_equality_method = false if (object.ReferenceEquals(value, null)) return; // dotnet_style_prefer_is_null_check_over_reference_equality_method = false if ((object)o == null) return; ```

mandel-macaque commented Mar 17, 2023

View reviewed changes

Comment thread .editorconfig Outdated

Update .editorconfig

7eed258

This comment has been minimized.

Sign in to view

rolfbjarne reviewed Mar 17, 2023

View reviewed changes

mandel-macaque commented Mar 17, 2023

View reviewed changes

Comment thread .editorconfig Outdated

Update .editorconfig

a22e639

This comment has been minimized.

Sign in to view

haritha-mohan approved these changes Mar 17, 2023

View reviewed changes

tj-devel709 approved these changes Mar 20, 2023

View reviewed changes

stephen-hawley approved these changes Mar 31, 2023

View reviewed changes

Merge branch 'main' into nullability-style

878fbba

This comment has been minimized.

Sign in to view

Merge branch 'main' into nullability-style

4040fe9

mandel-macaque merged commit 1681e9f into dotnet:main Jun 22, 2023

mandel-macaque deleted the nullability-style branch June 22, 2023 17:31

Conversation

mandel-macaque commented Mar 17, 2023

Uh oh!

mandel-macaque commented Mar 17, 2023

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

mandel-macaque commented Mar 17, 2023

Uh oh!

azure-pipelines Bot commented Mar 17, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

rolfbjarne left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

tj-devel709 left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 21, 2023

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 21, 2023

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 21, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

✅ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 21, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 21, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 21, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rolfbjarne left a comment •

edited

Loading