[NearbyInteraction] Updates for Xcode14 Beta 1 by tj-devel709 · Pull Request #15840 · dotnet/macios

tj-devel709 · 2022-09-01T14:25:32Z

No description provided.

rolfbjarne · 2022-09-01T14:48:28Z

+				if (_WorldTransformNotAvailable is null) {
+					unsafe {
+						MatrixFloat4x4 *pointer = (MatrixFloat4x4 *) Dlfcn.GetIndirect (Libraries.NearbyInteraction.Handle, "NINearbyObjectWorldTransformNotAvailable");
+						_WorldTransformNotAvailable = *pointer;


I think this will crash if executed on an earlier OS version (where the native field doesn't exist).

Something like this should work instead:

Suggested change

_WorldTransformNotAvailable = *pointer;

if (pointer == null)

throw new PlatformNotSupportedException ("This property is not supported on this version of the OS");

_WorldTransformNotAvailable = *pointer;

The property also needs availability attributes.

stephen-hawley · 2022-09-01T20:02:09Z

👀

tj-devel709 · 2022-09-02T13:02:30Z

Updating and want to rerun the failing addressbook tests in monotouch-tests and failing bcl test

tj-devel709 · 2022-09-02T19:11:19Z

More seemingly-unrelated test failures...

tj-devel709 · 2022-09-02T19:11:25Z

/azp run

azure-pipelines · 2022-09-02T19:12:07Z

Azure Pipelines successfully started running 1 pipeline(s).

vs-mobiletools-engineering-service2 · 2022-09-02T20:59:30Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
~~tvOS~~ (no change detected)
watchOS: vsdrops gist (No breaking changes)
~~macOS~~ (no change detected)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
~~tvOS~~: (empty diff detected)
MacCatalyst: vsdrops gist (No breaking changes)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 7269ce68968be51a33305225cc85c3f7c7a821fc [PR build]

vs-mobiletools-engineering-service2 · 2022-09-02T21:02:25Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1166.Monterey'
Hash: 7269ce68968be51a33305225cc85c3f7c7a821fc [PR build]

vs-mobiletools-engineering-service2 · 2022-09-02T21:25:39Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

introspection
xammac_tests
monotouch-test

Pipeline on Agent
Hash: 7269ce68968be51a33305225cc85c3f7c7a821fc [PR build]

vs-mobiletools-engineering-service2 · 2022-09-02T23:44:44Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 3 tests failed, 225 tests passed.

Failures

❌ bcl tests

1 tests failed, 68 tests passed.

Details

[xUnit] Mono SystemXunit/tvOS - simulator/Debug: Crashed

Html Report (VSDrops) Download

❌ introspection tests

1 tests failed, 12 tests passed.

Details

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ xcframework tests

1 tests failed, 7 tests passed.

Details

xcframework-test/watchOS 32-bits - simulator/Debug: TimedOut

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

tj_devel709 added 2 commits August 31, 2022 11:55

starting NearbyInteractions

f88415f

Allow manual bindings to pass

611cd93

tj-devel709 added the notes-mention Deserves a mention in release notes label Sep 1, 2022

tj-devel709 added this to the xcode14 milestone Sep 1, 2022

Remove extra file and spruce up some comments

c8ab78b

rolfbjarne requested changes Sep 1, 2022

View reviewed changes

tj_devel709 added 2 commits September 1, 2022 09:48

simplify if

0ec34eb

add attributes and null check to manual file

c735e82

rolfbjarne approved these changes Sep 1, 2022

View reviewed changes

mandel-macaque approved these changes Sep 1, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

legacy ios intro did not like double unsupported attributes

5eab7f2

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Sep 2, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'xcode14' into xcode14-NearbyInteraction-beta1

7269ce6

This comment has been minimized.

Sign in to view

chamons approved these changes Sep 6, 2022

View reviewed changes

mandel-macaque merged commit fe9c46c into dotnet:xcode14 Sep 6, 2022

Conversation

tj-devel709 commented Sep 1, 2022

Uh oh!

rolfbjarne Sep 1, 2022

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

stephen-hawley commented Sep 1, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tj-devel709 commented Sep 2, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tj-devel709 commented Sep 2, 2022

Uh oh!

tj-devel709 commented Sep 2, 2022

Uh oh!

azure-pipelines Bot commented Sep 2, 2022

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 2, 2022

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 2, 2022

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 2, 2022

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 2, 2022

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ bcl tests

❌ introspection tests

❌ xcframework tests

Successes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants