Repository navigation
[ExtensionKit] Add support for Xcode 14 beta 1 & 2 - #15548
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mandel-macaque
suggested changes
Jul 19, 2022
mandel-macaque
left a comment
mandel-macaque
left a comment
Contributor
There was a problem hiding this comment.
There are a few things that are missing for this to work.
- You need to update https://github.com/xamarin/xamarin-macios/blob/main/src/frameworks.sources since you need to process the code
- You need to add the new library paths here: https://github.com/xamarin/xamarin-macios/blob/main/tools/common/Frameworks.cs
I think that is all since this is a mac framework.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
SotoiGhost
force-pushed
the
ExtensionKit-xcode14
branch
from
July 25, 2022 21:19
1fc4c8c to
d71d0d9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rolfbjarne
requested changes
Aug 18, 2022
rolfbjarne
left a comment
rolfbjarne
left a comment
Member
There was a problem hiding this comment.
You also need to add an entry in this list:
| { "ScreenCaptureKit", "ScreenCaptureKit", 12,3 }, | ||
|
|
||
| { "BackgroundAssets", "BackgroundAssets", 13,0}, | ||
| { "ExtensionKit", "ExtensionKit", 13,0 }, |
Contributor
Author
There was a problem hiding this comment.
I did a rebase, I'm seeing this now, don't know what happened
Member
|
Also make sure to update the PR to the latest beta |
rolfbjarne
approved these changes
Aug 19, 2022
SotoiGhost
force-pushed
the
ExtensionKit-xcode14
branch
from
August 22, 2022 18:09
6e56ccc to
1aa4706
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
@SotoiGhost please look at the intro failures |
SotoiGhost
force-pushed
the
ExtensionKit-xcode14
branch
from
August 26, 2022 16:25
1aa4706 to
a3c510f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mandel-macaque
approved these changes
Sep 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.