Skip to content

[storekit] Add nullability to (generated and manual) bindings - #14896

Merged
tj-devel709 merged 7 commits into
dotnet:mainfrom
tj-devel709:Nullable-StoreKit
May 17, 2022
Merged

tj-devel709 merged 7 commits into
dotnet:mainfrom
tj-devel709:Nullable-StoreKit

Conversation

@tj-devel709

Copy link
Copy Markdown
Member

This PR aims to bring nullability changes to StoreKit.
Following the steps here:

  1. I am adding nullable enable to all manual files that are not "API_SOURCES" in src/frameworks.sources and making the required nullability changes
  2. Changing any == null or != null to is null and is not null

@tj-devel709 tj-devel709 added the not-notes-worthy Ignore for release notes label May 4, 2022
@tj-devel709 tj-devel709 added this to the Future milestone May 4, 2022
Comment thread src/StoreKit/SKCloudServiceSetupOptions.cs Outdated
@vs-mobiletools-engineering-service2

This comment has been minimized.

Comment thread src/StoreKit/SKCloudServiceSetupOptions.cs Outdated
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Comment thread src/StoreKit/SKCloudServiceSetupOptions.cs Outdated
@vs-mobiletools-engineering-service2

This comment has been minimized.

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After @mandel-macaque 👍

@tj-devel709

Copy link
Copy Markdown
Member Author

@mandel-macaque @rolfbjarne Updated!

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@tj-devel709

Copy link
Copy Markdown
Member Author

Unrelated Test Failures due to unrelated Timeouts!

@tj-devel709

Copy link
Copy Markdown
Member Author

This one is ready to merge after approval from @mandel-macaque

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

🔥 Tests failed catastrophically on VSTS: simulator tests iOS (no summary found). 🔥

Result file D:\a\1\s\Reports\TestSummary-simulator\TestSummary.md not found.

Pipeline on Agent XAMBOT-1107.Monterey'
Merge 3afbec6 into 0ec49ff

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1109.Monterey'
Hash: ea2bf7fab89e54ca88e9fc9314d63e09a4fd79f8

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: ea2bf7fab89e54ca88e9fc9314d63e09a4fd79f8

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

📋 [PR Build] API Diff 📋

API Current PR diff

ℹ️ API Diff (from PR only) (please review changes)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

✅ Generator Diff (no change)

Pipeline on Agent XAMBOT-1017.Monterey'
Hash: ea2bf7fab89e54ca88e9fc9314d63e09a4fd79f8

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • xammac_tests
  • monotouch-test

Pipeline on Agent
Hash: ea2bf7fab89e54ca88e9fc9314d63e09a4fd79f8

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [CI Build] Tests passed on VSTS: simulator tests iOS. ✅

Tests passed on VSTS: simulator tests iOS.

🎉 All 148 tests passed 🎉

Pipeline on Agent XAMBOT-1096.Monterey'
Merge ea2bf7f into 5249316

@tj-devel709
tj-devel709 merged commit e6031a7 into dotnet:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants