Repository navigation
Eliminate redundant Correctness CI stage by merging into Build - #7594
Merged
Merged
Conversation
The Correctness stage was a full redundant rebuild (restore + slngen + restore + build) that ran in parallel with the Build stage, solely to check warnings-as-errors. This is now handled directly in the Build stage jobs by using the default warnAsError=1 setting (removing the explicit warnAsError: 0 overrides in the public pipeline). Changes: - azure-pipelines.yml: Remove correctness stage, remove it from validateDependsOn - azure-pipelines-public.yml: Remove correctness stage, remove warnAsError: 0 from Windows and Ubuntu build jobs (default is already 1) - azure-pipelines-unofficial.yml: Remove correctness stage
Copilot created this pull request from a session on behalf of
adamsitnik
June 30, 2026 14:13
View session
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1487966&view=codecoverage-tab |
adamsitnik
approved these changes
Jun 30, 2026
adamsitnik
left a comment
adamsitnik
left a comment
Member
There was a problem hiding this comment.
LGTM, if other maintainers are going to be supportive, I am going to introduce plenty of other similar changes that are going to reduce the total CI time.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the standalone Correctness CI stage (which rebuilt the repo solely to enforce warnings-as-errors) and relies on the existing Build stage behavior to enforce the same policy, reducing duplicated work and CI runtime.
Changes:
- Removed the redundant
correctnessstage from the official, public, and unofficial Azure Pipelines definitions. - Updated
validateDependsOnin the official pipeline to no longer reference the removed stage. - In the public pipeline, removed explicit
warnAsError: 0overrides so Build jobs use the template default (warnAsError: 1).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| azure-pipelines.yml | Removes correctness stage and drops it from validateDependsOn, relying on the Build stage/template defaults. |
| azure-pipelines-public.yml | Removes the correctness stage and ensures Build jobs now run with template-default warnings-as-errors. |
| azure-pipelines-unofficial.yml | Removes the redundant correctness stage from the unofficial pipeline. |
Copilot
AI
changed the title
Eliminate redundant Correctness CI stage by merging into Build
Enable MSBuild graph-based builds
Jun 30, 2026
adamsitnik
requested changes
Jun 30, 2026
Contributor
Author
|
@adamsitnik I've opened a new pull request, #7595, to work on those changes. Once the pull request is ready, I'll request review from you. |
dotnet-policy-service
Bot
added
waiting-author-feedback 📭
adamsitnik
changed the title
adamsitnik
approved these changes
Jun 30, 2026
wtgodbe
approved these changes
Jun 30, 2026
adamsitnik
enabled auto-merge (squash)
June 30, 2026 17:58
evgenyfedorov2
approved these changes
Jun 30, 2026
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1488286&view=codecoverage-tab |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Correctness stage runs a full rebuild (restore → slngen → restore → build) solely to enforce warnings-as-errors, duplicating work already done by the Build stage. This wastes ~15-20 min of agent compute per pipeline run.
Changes
correctnessstage and its entry invalidateDependsOncorrectnessstage; removewarnAsError: 0overrides from Windows/Ubuntu build jobs so they use the template default ofwarnAsError: 1correctnessstageWhy this is safe
The
BuildAndTest.ymltemplate already defaultswarnAsErrorto1. The official and unofficial pipelines never overrode this in their Build jobs—they were already building with warnings-as-errors. Only the public pipeline had explicitwarnAsError: 0, which is now removed.