Repository navigation
Add XML documentation to JValue struct - #11354
Merged
Merged
Conversation
1 of 7 tasks
Agent-Logs-Url: https://github.com/dotnet/android/sessions/a7333575-ebda-4bf1-95a4-d10a0cae606e Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add XML documentation to JValue struct
Add XML documentation to May 14, 2026
JValue struct
jonathanpeppers
marked this pull request as ready for review
May 14, 2026 21:53
Contributor
There was a problem hiding this comment.
Pull request overview
Adds XML documentation to the public Android.Runtime.JValue struct to make the JNI interop surface discoverable in IDE IntelliSense and generated API docs.
Changes:
- Added struct-level
jvalueusage and linking to the JNI type specification. - Added XML docs for
JValue.Zeroand allJValueconstructors, including theIJavaObjectnull-handling behavior.
jonathanpeppers
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JValueis a fundamental JNI interop type with zero documentation on any public member. Adds///XML doc comments to the struct and all 10 public members.jboolean,jbyte,jchar,jshort,jint,jlong,jfloat,jdouble,jobject)IJavaObjectconstructor documents null-handling (extractsHandle, passesIntPtr.Zerofor null)JValue.Zerofield documentedNo logic changes.