Repository navigation
Ignore submodules in fail-on-dirty-tree CI check - #10927
Merged
Merged
Conversation
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jonathanpeppers
March 13, 2026 00:00
View session
jonathanpeppers
marked this pull request as ready for review
March 13, 2026 13:14
jonathanpeppers
requested review from
grendello,
jonathanpeppers and
simonrozsival
as code owners
March 13, 2026 13:14
jonathanpeppers
approved these changes
Mar 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CI “fail on dirty tree” template to avoid failing builds due to untracked/dirty content inside Git submodules (which the build does not directly control).
Changes:
- Add
--ignore-submodulesto the informationalgit statusoutput. - Add
--ignore-submodulesto thegit status --porcelaincheck that determines whether to fail the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fail-on-dirty-tree.yamlpipeline step fails when submodules (external/Java.Interop,external/debugger-libs,external/xamarin-android-tools) contain untracked content. We don't control submodule working tree state, so the check should exclude them.--ignore-submodulesto bothgit statuscalls (display and porcelain check)