Repository navigation
Improve device UUID filtering logic - #4956
Conversation
|
is there any reason why this changes the indentation of the entire file? |
|
It's my IDE (CLION). I'll fix it. Sorry. |
|
Since device UUID's aren't guaranteed to be unique I don't think this is good as a general solution. Even if it helped in your case. Edit: actually I see now that the example shown is unique so maybe that isn't true ? Then it would be fine I guess. |
"Implementations should return deviceUUID values which are likely to be unique even in the presence of multiple Vulkan implementations (such as a GPU driver and a software renderer; two drivers for different GPUs; or the same Vulkan driver running on two logically different devices)." So. Yes, there are unique. |
I don't think they're guaranteed to be unique across the entire population of cards and vendors, however the odds of someone having two cards with the same UUID in the same system should be quite astronomical. At least that's the gist I'm getting from the documentation. |
|
Indentation has been fixed now, @doitsujin. Let me know if anything else needs adjustment. |
doitsujin
left a comment
There was a problem hiding this comment.
Just a nit now.
I will likely refactor this whole area in the near future so we can skip devices that don't support the required feature set beyond just the core Vulkan version, but in the meantime this will do.
This is a replacement for PR #2408.
In relation to #2036.
This PR improves and corrects the UUID filtering logic in
DxvkDeviceFilter,ensuring proper selection based on Vulkan
deviceUUID. It also prevents memoryleaks by cleaning up rejected adapters and simplifies the adapter query logic.
Closes #2408.