Repository navigation
Don't use sRGB swapchain formats - #4778
Merged
Merged
Conversation
Third-party software is broken and doesn't understand non-linear formats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third-party software like RTSS doesn't handle
_SRGBformats properly, so always create swapchains with a plain_UNORMformat and useVK_KHR_swapchain_mutable_formatin order to keep the_SRGBformat internally, which is necessary for the HUD and software cursor to be rendered correctly.On the other hand, this change may regress SDR games on some HDR setups on Windows because
UNORMformats may also get interpreted the wrong way by some drivers.This may also regress third-party software that isn't aware of swapchain create flags or
pNextchains.