[5.x]: Deleting a completed order with a custom line item throws InvalidConfigException

[denisyilmaz]

What happened?

Description

Completed orders that contain a custom line item cannot be deleted, neither from the CP nor via Elements::deleteElement(). Order::afterDelete() loops over the line items captured in beforeDelete() and calls $lineItem->getPurchasable() on each to refresh the stock cache. getPurchasable() throws for LineItemType::Custom, so the delete transaction rolls back.

Steps to reproduce

1. Complete an order that contains a custom line item.
2. Delete the order from the Orders index.

Expected behavior

The order is deleted. Custom line items have no purchasable and no inventory, so they should be skipped.

Actual behavior

yii\base\InvalidConfigException: Cannot get a purchasable for a custom line item at src/models/LineItem.php:838, called from src/elements/Order.php:3816 (afterDelete).

Suggested fix:

skip custom line items in the loop, e.g. if ($lineItem->type === LineItemType::Custom) { continue; }. Same class of bug as #4337 and #3733.

Craft CMS version

5.11.1

Craft Commerce version

5.7.4

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

[linear-code]

COM-671

[nfourtythree]

Hi @denisyilmaz

Thank you for bringing this to our attention.

We have pushed a fix which will be included in the next release of Commerce.

To get this early, change your craftcms/commerce requirement in your project's composer.json to:

"require": {
  "craftcms/commerce": "5.x-dev as 5.7.4",
  "...": "..."
}

Then run composer update.

Thanks!

[nfourtythree]

The fix for this has been included in the 5.7.5 release of Commerce which is out now.

Thanks!