[5.x]: Shipping Line Item Being Removed from Order and Marked As Overpaid

[RitterKnightCreative]

What happened?

Description

I believe this started happening on the Craft Commerce 5.7 branch so I'm not sure if this is a Commerce bug or a Postie bug.

We recently upgraded Commerce to 5.7.1 (from 5.6.x) and on a few orders we're seeing shipping being dropped as a line item on the order.

However, in the sidebar, the shipping method still appears to be retained on the order so it doesn't appear to be completely "missing."

However, this is making the affected orders appear overpaid.

It's not happening all of the time but the last 5 orders that I've seen, 2 of those were marked as overpaid. It's almost like after the order is being completed, Commerce is recalculating the order and since the shipping is being calculated in real time, it throws the line item out.

FWIW I've also filed a cross referenced bug report with Verbb. Not sure how to go about troubleshooting this.

Steps to reproduce

1. Customer checks out
2. On completion of the order, some orders appear to be overpaid with shipping being "removed".

Expected behavior

1. Customer checks out
2. On completion of the order, orders shipping remains in tact and not removed.

Craft CMS version

5.10.12

Craft Commerce version

5.7.1

PHP version

8.3

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

Postie

[linear-code]

COM-594

[RitterKnightCreative]

@nfourtythree @lukeholder just making sure you saw this.

After some additional review, we are putting some adjustments on the price that Postie spits out... for example, we tack on an additional $6 if the address is residential and do some markups depending on the order's contents. it looks leek this might be a combination of my code that runs based on a couple Postie events and a Commerce bug.

As a follow-up, it also looks like Commerce is recalculating the order when an order status changes as well. I believe that's not supposed to happen? Those adjustments should be locked in. We had a customer get charged the correct amount but I noticed it went to overpaid when the order was then shipped and it dropped our adjustments. It seems like it's recalculating Postie's data in real time now?

[lukeholder]

@RitterKnightCreative

Thanks for your patience.

Very hard to diagnose this and I was looking into it, but just seen Verbb responded on the related issue you lodged: verbb/postie#174 (comment).

Let me know if their updates fixes the issue.

[nfourtythree]

Hi @RitterKnightCreative

We have just pushed up a fix that could be related to this issue. The fix will be included in the next release of Commerce.

To get this early, change your craftcms/commerce requirement in your project's composer.json to:

"require": {
  "craftcms/commerce": "5.x-dev as 5.7.1",
  "...": "..."
}

Then run composer update.

Thanks!

[nfourtythree]

Commerce 5.7.2 has now been released with this fix included.

Thanks!