[5.x]: Variant slide-out tabs not switching when Variant has a related sale

[robzor]

What happened?

Description

Hi there,

I've just upgraded a site with a lot of variants to Craft 5 Commerce.

I am currently tweaking the variant field layout for the new slide out panel and have started adding tabs.

For any product that has a 'Show related Sales' dropdown, the tabs do not switch, the fields instead get appended to the bottom of the current tab.

Possibly relevant: I have not migrated the Sales rules to Catalog Pricing Rules so perhaps this is why the bug hasn't been caught yet?

Steps to reproduce

1. Add some tabs to a variant product layout
2. Choose a variant that is associated with a Sale
3. Open the variant slide out and try to click between the tabs

Expected behavior

The tab's content switches.

Actual behavior

The tab's content gets appended to the bottom of the current tab.

Craft CMS version

5.10.10

Craft Commerce version

5.6.7

PHP version

8.3.31

Operating system and version

No response

Database type and version

MySQL

Image driver and version

No response

Installed plugins and versions

Blitz	5.12.10
Cookiebot	dev-master
Cookies	5.0.0
Craftagram	4.3.0
Craft Commerce	5.6.7
Elements Panel	3.0.1
Empty Coalesce	5.0.0
Expanded Singles	3.0.3
Gift Voucher	4.0.15
Mix	v1.8.1
Navigation	3.0.22
oEmbed	3.2.2
PayPal Checkout for Craft Commerce	3.1.0
Phone Number	3.0.0
Redactor	4.2.0
Redirects	5.0.14
SEOmatic	5.1.21
Servd Assets and Helpers	4.2.6
Sprig	3.7.3
Stripe for Craft Commerce	5.1.0.3
Super Table	4.0.6

[linear-code]

COM-591

[robzor]

Just saw there was an upgrade for Craft and Commerce so just tested this in Commerce 5.7.0 / Craft 5.10.11 and it still occurs.

[nfourtythree]

Hi @robzor

Thank you for reporting this.

We have just pushed a fix which will be included in the next release of Commerce.

To get this early, change your craftcms/commerce requirement in your project's composer.json to:

"require": {
  "craftcms/commerce": "5.x-dev as 5.7.0",
  "...": "..."
}

Then run composer update.

Thanks!

[robzor]

Thank you :)

[nfourtythree]

Commerce 5.7.1 has now been released with this fix included.

Thanks!