Repository navigation
Addresses failed Precondition when rendering vertically overflowing glyphs - #1805
Merged
Merged
Conversation
github-actions
Bot
added
VT: Backend
christianparpart
force-pushed
the
fix/minors
branch
2 times, most recently
from
November 23, 2025 21:01
c6b663b to
0d5c497
Compare
christianparpart
force-pushed
the
fix/minors
branch
from
November 23, 2025 21:03
0d5c497 to
acec32e
Compare
Signed-off-by: Christian Parpart
Signed-off-by: Christian Parpart
Signed-off-by: Christian Parpart
christianparpart
force-pushed
the
fix/minors
branch
from
November 23, 2025 21:08
acec32e to
b349139
Compare
github-actions
Bot
added
frontend
Yaraslaut
approved these changes
Nov 25, 2025
Yaraslaut
left a comment
Yaraslaut
left a comment
Member
There was a problem hiding this comment.
lgtm, thanks,
maybe we should consider adding auto clang-formating of the PRs in here as well
Member
Author
@Yaraslaut I am sorry to say this, but I am currently strongly against it, tbh. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1778.
and yeah, also bump clang-format to version 21.