Repository navigation
Further improvements to tabs handling (add MoveTabToLeft / MoveTabToRight / MoveTabTo actions) - #1695
Merged
Merged
Conversation
…usTab` Signed-off-by: Christian Parpart
Signed-off-by: Christian Parpart
christianparpart
force-pushed
the
improvement/tabs
branch
from
January 1, 2025 19:32
7a43dd4 to
0a0afaf
Compare
christianparpart
changed the title
christianparpart
marked this pull request as ready for review
January 1, 2025 19:33
…o the left/right Signed-off-by: Christian Parpart
christianparpart
force-pushed
the
improvement/tabs
branch
from
January 1, 2025 19:35
0a0afaf to
a5f8dd3
Compare
… tab Signed-off-by: Christian Parpart
christianparpart
force-pushed
the
improvement/tabs
branch
from
January 1, 2025 20:10
2a17dfa to
9f3ec38
Compare
christianparpart
changed the title
…ous tab when only one tab is present :) Signed-off-by: Christian Parpart
Yaraslaut
approved these changes
Jan 1, 2025
Yaraslaut
left a comment
Yaraslaut
left a comment
Member
There was a problem hiding this comment.
Nice, great changes
We can switch to internal handling of actions in another PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initial support of moving tabs
@Yaraslaut I think we should give
TerminalSessionaccess to its owning list of tabs (TerminalSessionManagercurrently).Maybe the name isn't the best, when thinking of tabs alone. In the long term, we might think of a tree data structure in order to implement tiling-like splits/pane views.
So whatever the DS / API will be, a leaf node (like a terminal session) should always have access to its parent node. What do you think? IMHO, this could also simplify the logic in the QML side (something I failed to revive in my head today)
Update
Changes:
CreateTabto sometimes not spawn more than one tab (fixed implicitly)closes #1692
closes #1691