Repository navigation
Restrict font locator configurability down to native and mock. - #1538
Merged
Merged
Conversation
github-actions
Bot
added
documentation
christianparpart
force-pushed
the
improvement/cleanup-font-locator-use
branch
from
June 25, 2024 07:22
326a785 to
c37d1f1
Compare
Yaraslaut
reviewed
Jun 25, 2024
Yaraslaut
reviewed
Jun 25, 2024
christianparpart
force-pushed
the
improvement/cleanup-font-locator-use
branch
3 times, most recently
from
June 25, 2024 20:09
7461ba1 to
f428579
Compare
…tudio 2022 native VCPKG support)
This is mainly to lower the dependency count on at least Windows operating system. Also, there's no need to be that explicit. We still need a way to explicitly set the font locator to `mock` (xor `native`) - but that's it. Signed-off-by: Christian Parpart
christianparpart
force-pushed
the
improvement/cleanup-font-locator-use
branch
from
June 30, 2024 20:29
f428579 to
65f0180
Compare
Member
Author
|
I just rebased on top of latest master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I mainly wanted to get rid of the fontconfig dependency on Windows platform. There's no real need for it, especially since we have a DirectWrite font locator implementation. I'd rather focus on improving that one (if needed) than supporting two different one on a single platform.