Skip to content

Replace all occurrences of OS/X - #1462

Merged
christianparpart merged 1 commit into
contour-terminal:masterfrom
fingolfin:mh/osx
Feb 18, 2024
Merged

christianparpart merged 1 commit into
contour-terminal:masterfrom
fingolfin:mh/osx

Conversation

@fingolfin

Copy link
Copy Markdown
Contributor

The Macintosh operating system underwent many name changes over the years,
from being nameless to "System" to "Mac OS" to "OS X" to "macOS".

But at no point in time was it ever called "OS/X" :-)

@github-actions github-actions Bot added documentation Improvements or additions to documentation frontend Contour Terminal Emulator (GUI frontend) CI GitHub Actions & CI VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library fonts font rasterization and text shaping API and platform implementations labels Feb 10, 2024

@uspasojevic96 uspasojevic96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick review, what I would NOT do is to edit existing changelog, but add new entry for the change of naming

Comment thread docs/configuration/advanced/misc.md Outdated
Comment thread src/contour/contour.yml Outdated
Comment thread src/contour/contour.yml Outdated
@christianparpart

christianparpart commented Feb 10, 2024 •

Copy link
Copy Markdown
Member

Many thanks, @fingolfin.

I think I'm used to name it like that from the time it was named like that (just without the slash):

image [1]

Not sure were the slash is coming from, in my memories :)

@christianparpart christianparpart added the no changelog Tells the CI to not require a changelog entry label Feb 10, 2024
The Macintosh operating system underwent many name changes over the years,
from being nameless to "System" to "Mac OS" to "OS X" to "macOS".

But at no point in time was it ever called "OS/X" :-)
@fingolfin

Copy link
Copy Markdown
Contributor Author

Did a quick review, what I would NOT do is to edit existing changelog,

But why not? Would you not fix typos in them either?

but add new entry for the change of naming

OK, if you want a changelog entry for a typo fix, I am happy to add it -- except I have no idea how. I am guessing metainfo.xml might be the changelog file (though I am not sure given its name)? But what is the format, where would this be added?

@christianparpart

Copy link
Copy Markdown
Member

contour/metainfo.xml

Lines 107 to 113 in cdb2e16

<release version="0.4.4" urgency="medium" type="development">
<description>
<ul>
<li> Fixes corruption of sixel image on high resolution (#1049) li>
ul>
description>
release>

Hey. This is going to be the changelog for the next release. You can simply add yourself at the end of it.

Changelogs can of course be typo-fixed, but I remember from other big open source projects that change logs are only about to be changed for present/future entries, not touching past entries. So I think that's a philosophy thing :)

@christianparpart

Copy link
Copy Markdown
Member

Hey @fingolfin. Can I help you with anything?

@fingolfin

Copy link
Copy Markdown
Contributor Author

I don't time to work on this outside of weekends. Anyway, this is a trivial search&replace change. Feel free to finish the PR in whichever way you want it, or to close it / do your own version of it.

@christianparpart
christianparpart merged commit ca136dd into contour-terminal:master Feb 18, 2024
@christianparpart

Copy link
Copy Markdown
Member

I've added the changelog entry after the merge. Many thanks @fingolfin for your contribution and support. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI GitHub Actions & CI documentation Improvements or additions to documentation fonts font rasterization and text shaping API and platform implementations frontend Contour Terminal Emulator (GUI frontend) no changelog Tells the CI to not require a changelog entry VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants