php 8.1 JsonSerializable::jsonSerialize() return type deprecation warning

[davidcorreia]

for future integration with php8.1

PHP Deprecated: Return type of chillerlan\Settings\SettingsContainerAbstract::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/app/vendor/chillerlan/php-settings-container/src/SettingsContainerAbstract.php on line 168

however qrcode is showing and working :)

[codemasher]

Thanks for the report! I moved the discussion to the appropriate repo.

[codemasher]

I have released an update that should fix the warning. It should be gone after a composer update - please let me know in case it persists. Thanks!

[davidcorreia]

hmm weird... i just saw that the issue is related to php-settings-container however the package i'm using is php-qrcode

$ cat composer.json 
{
    "require": {
        "phpmailer/phpmailer": "^6.5",
        "chillerlan/php-qrcode": "^4.3"
    }
}

[codemasher]

Yes indeed, everything fine! This is a dependency of chillerlan/php-qrcode and since the deprecated warning is not related to the QRCode library i moved the discussion over here. You should see a message during the composer update like this:
Upgrading chillerlan/php-settings-container (2.1.3 => 2.1.4)

[davidcorreia]

ahhh, makes sence :)

confirm the upgrade Upgrading chillerlan/php-settings-container (1.2.1 => 2.1.4): Extracting archive

however (changed line to 157)

PHP Deprecated: Return type of chillerlan\Settings\SettingsContainerAbstract::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/app/vendor/chillerlan/php-settings-container/src/SettingsContainerAbstract.php on line 157

[codemasher]

oof, that's weird. It was worth a try though - one would think that no return type is actually compatible with mixed but here we are. The thing is that it is impossible to fix without breaking PHP 7.4 versions as the mixed return type was introduced in PHP 8. So for now i can only advise to ignore the warning. In future there will be PHP8-only releases - but not before 7.4 EOL.

[davidcorreia]

:)

[codemasher]

Ok, wait. I am not smart and i forgot that i could simply add attributes and they won't break older PHP versions as they are simply ignored 😄
So i have pushed a fix for the fix and re-released 2.1.4. You might need to delete the composer.lock (or push the update button a bit harder) to fetch the new release and the warning should be gone for good. Cheers!

Edit: it works without deleting anythig - just composer update as usual:
Upgrading chillerlan/php-settings-container (2.1.4 a2767d6 => 2.1.4 1beb7df)

[davidcorreia]

Amazing! :D
i confirm no errors or warnings now

[Flaschenzug]

I still do get the warning (deprecated) - and I just installed the newest version from composer.
Using php 8.1

Return type of chillerlan\Settings\SettingsContainerAbstract::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

SettingsContainerAbstract.php:168

[davidcorreia]

have you tried to remove the vendor folder, and re-install via composer?

[codemasher]

@Flaschenzug are you sure you're using the latest version? CI would fail if that issue was still existent. The latest version (v3.1.0) is intended for PHP 8.1+ and implements this method as dictated by the interface without issues. The PHP 7.4+ release as of v2.1.4 uses the attribute and shouldn't cause an issue either:

php-settings-container/src/SettingsContainerAbstract.php

Lines 157 to 160 in 1beb7df

	#[\ReturnTypeWillChange]
	public function jsonSerialize():array{
	return $this->toArray();
	}

[Flaschenzug]

public function jsonSerialize(){
		return $this->toArray();
	}

I guess I have an old PHP Version on my computer. So composer picked the older version.
Using "--ignore-platform-req=php" it works perfectly and I got the newest one.

Thanks for your help

[DevelopByte]

I have this error:

Deprecated: Return type of BN\BN::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /vendor/ccxt/ccxt/php/static_dependencies/BN/BN.php on line 95

php -v PHP 8.1.13 (cli) (built: Dec 8 2022 20:54:05) (NTS) Copyright (c) The PHP Group Zend Engine v4.1.13, Copyright (c) Zend Technologies

How I can fixed this?

[codemasher]

Have you read and tried to follow the above suggestions?