Repository navigation
feature: ReflectionSource and DictionarySource - #426
Merged
Merged
Conversation
* Make ReflectionSource.TypeCache static * Control size of ReflectionSource.TypeCache, remove oldest item first * dynamics in DictionarySource also use case-sensitivity setting * Cache for IReadOnlyDictionary has instance scope
Only before NETCore3.1, the dictionary is not ordered by insertion order.
* Add comment about handling case-sensitivity * Add test for: When there are multiple members with the same name but different case, the first member is used
* for DictionarySource * for ReflectionSource
axunonb
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
===================================
Coverage 97% 97%
===================================
Files 96 96
Lines 3400 3422 +22
===================================
+ Hits 3282 3304 +22
Misses 118 118 ☔ View full report in Codecov by Sentry. |
axunonb
commented
Jun 29, 2024
karljj1
approved these changes
Jul 2, 2024
Member
Author
|
Thanks for the review. Wiki is updated accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #425
Changes to
ReflectionSourceReflectionSource.TypeCacheto be static, shared across all instances.ReflectionSource.TypeCache. When the cache exceeds the maximum size limit, it now removes the oldest entry first, adhering to a First-In-First-Out (FIFO) strategy.CaseSensitivityType.CaseInsensitive: Clarified that in scenarios where multiple members share the same name but differ in case, the first encountered member will be selected.Updates to
DictionarySourceIReadOnlyDictionaryis deliberately scoped to the instance level.