Skip to content

Fix: Returning a StringBuilder exceeding default capacity to StringBuilderPool - #397

Merged
axunonb merged 1 commit into
axuno:mainfrom
axunonb:pr/stringbuilder-pool
May 20, 2024
Merged

axunonb merged 1 commit into
axuno:mainfrom
axunonb:pr/stringbuilder-pool

Conversation

@axunonb

@axunonb axunonb commented May 20, 2024

Copy link
Copy Markdown
Member

Call StringBuilder.Clear() before setting the default capacity. The other way around throws.

…ilderPool

Call StringBuilder.Clear() before setting the default capacity. The other way around throws.
@codecov

codecov Bot commented May 20, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96%. Comparing base (023a4ed) to head (c3324d4).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #397   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        92     92           
  Lines      3226   3226           
===================================
  Hits       3110   3110           
  Misses      116    116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@axunonb
axunonb merged commit dfd1d85 into axuno:main May 20, 2024
@axunonb
axunonb deleted the pr/stringbuilder-pool branch May 20, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant