Repository navigation
Conversation
This is the first part of a series of PRs split of from the large proof-of-concept PR ad-freiburg#916, which realizes SPARQL 1.1 Update
…s from Johannes' review
This PR is from June 2023. Since then, quite a bit of code that is relevant for this PR has been refactored. In particular: the `Permutation` class, the `CompressedRelationWriter` and the index building functions in `IndexImpl`. Mostly, this refactoring has made the code in this PR simpler. There is still some akwardness in `LocatedTriplesTest.cpp` because we want to build an index from `Id` triples there (and not from Turtle input). Now evertyhing compiles and runs through again. Various tests in `LocatedTriplesTest` fail, that's what I will look at next.
But not functional yet
This makes the actual changes hard to spot
Both cases would have done a full scan anyway, so we can do that directly without retrieving the relation metadata.
# Conflicts: # test/ValueIdTest.cpp
Member
Author
Outdated performance testing for a first implementationSome data:
~400k
~8M
|
Merged
# Conflicts: # src/global/IdTriple.h # src/index/IndexFormatVersion.h # src/index/LocatedTriples.cpp # src/index/LocatedTriples.h # test/CMakeLists.txt # test/IdTripleTest.cpp # test/LocatedTriplesTest.cpp
# Conflicts: # src/engine/sparqlExpressions/SparqlExpressionValueGetters.cpp
|
hannahbast
changed the title
# Conflicts: # src/index/CMakeLists.txt
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement SPARQL 1.1 Update support. This is an overarching PR that contains the latest implementation. It will be merged into the main branch one part after another. See #1379, #1429 for the parts.
The current state is most likely broken. It is not planed to bring this PR back to a working state until more of the parts are done. The effort required to keep up with the rest of the code base and ensure that this PR is (at least somewhat) bug free is currently to large to be worthwhile.