Repository navigation
Implement broker-listener WebSocket connectivity probes. - #4753
Merged
Merged
Conversation
salmanmkc
approved these changes
Oct 1, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The probe has an endpoint-scheme incompatibility plus retry and close-path correctness issues.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Adds a broker-listener WebSocket connectivity probe with telemetry and proxy support.
Changes:
- Adds authenticated WebSocket connection and retry handling.
- Starts probes from job variables and records results as job telemetry.
- Extends runner proxy handling for
ws/wss.
| File | Description |
|---|---|
src/Sdk/WebApi/WebApi/BrokerHttpClient.cs |
Adds WebSocket connection support. |
src/Sdk/DTWebApi/WebApi/WellKnownDistributedTaskVariables.cs |
Defines the probe URL variable. |
src/Sdk/DTWebApi/WebApi/BrokerWebSocketProbeResult.cs |
Adds the telemetry result model. |
src/Runner.Worker/JobExtension.cs |
Manages probe lifecycle and telemetry. |
src/Runner.Sdk/Util/VssUtil.cs |
Configures proxy support for raw HTTP handlers. |
src/Runner.Sdk/RunnerWebProxy.cs |
Routes WebSocket schemes through configured proxies. |
src/Runner.Common/BrokerServer.cs |
Implements the WebSocket probe loop. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.