Repository navigation
Fixed arguments on appimage - #2818
Conversation
redsigma
changed the title
| - export QT_PLUGIN_PATH="${HERE}"/usr/lib/qt4/plugins/:"${HERE}"/usr/lib/i386-linux-gnu/qt4/plugins/:"${HERE}"/usr/lib/x86_64-linux-gnu/qt4/plugins/:"${HERE}"/usr/lib32/qt4/plugins/:"${HERE}"/usr/lib64/qt4/plugins/:"${HERE}"/usr/lib/qt5/plugins/:"${HERE}"/usr/lib/i386-linux-gnu/qt5/plugins/:"${HERE}"/usr/lib/x86_64-linux-gnu/qt5/plugins/:"${HERE}"/usr/lib32/qt5/plugins/:"${HERE}"/usr/lib64/qt5/plugins/:"${QT_PLUGIN_PATH}" | ||
| - EXEC=$(grep -e '^Exec=.*' "${HERE}"/*.desktop | head -n 1 | cut -d "=" -f 2- | sed -e 's|%.||g') | ||
| - exec ${EXEC} "$@" | ||
| - EXEC="${HERE}/usr/share/@@APPNAME@@/@@APPNAME@@" |
There was a problem hiding this comment.
Should be EXEC="${HERE}/usr/share/@@APPNAME@@/@@BINARY_NAME@@" (same thing for the one underneath).
There was a problem hiding this comment.
i think build.sh has to be changed because @@BINARY_NAME@@ doesnt exist there
There was a problem hiding this comment.
Sorry about that, I didn't see that there was drift in the variable names... I will need to fix that.
There was a problem hiding this comment.
which variables need fixing ? I can take a look on that and include it in this PR
There was a problem hiding this comment.
in
sed -i "s|@@NAME@@|${APP_NAME}|g" recipe.yml
sed -i "s|@@APPNAME@@|${BINARY_NAME}|g" recipe.yml
sed -i "s|@@BINARY_NAME@@|${BINARY_NAME}|g" recipe.yml
APP_NAME -> NAME
BINARY_NAME -> APPNAME
It should be
sed -i "s|@@APP_NAME@@|${APP_NAME}|g" recipe.yml
sed -i "s|@@BINARY_NAME@@|${BINARY_NAME}|g" recipe.yml
Thx
There was a problem hiding this comment.
made the change. If you spot any issues let me know
There was a problem hiding this comment.
Sorry, you forgot to make the changes in the recipe.yml...
021f6b4 to
96ba126
Compare
fbb2ea6 to
04b8e8a
Compare
|
Thx |
2 participants
When doing commands such as below, it opens an instance of codium instead of listing active extensions in cli or installing extensions.
This PR fixes that by using a simpler approach rather than adjusting for each possible command. The following syntax will properly work and installing extensions are also properly working even with a custom --extensions-dir
For running the app normally you can still use the following