Repository navigation
Bug/red5dev 2425 - #484
Merged
Merged
Bug/red5dev 2425#484
Conversation
…connection/listener joins [AUTO-724]
… joins [AUTO-724] - ScopeResolver arms an idle check with a 30s grace period on rooms it creates, so a room left behind by a rejected or aborted request is removed - The keep alive job reschedules for remaining retention time instead of giving up, and defers when blocked by an in-flight connect or child add, a connection not yet removed, or a child room / in-use broadcast scope; the event that clears the blocker resumes the check - Shared object children no longer pin a room, matching previous behavior - A sooner check replaces a pending later one, and the job clears its reference under the scope monitor before checking - addChildScope no longer holds the scope monitor across handler callbacks; a pending child add count guards removal instead
mondain
approved these changes
Sep 17, 2026
mondain
left a comment
mondain
left a comment
Member
There was a problem hiding this comment.
Looks fine, I'm just leery about bumping mina to 2.2.x as it spiders outward in many places.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
This PR fixes RED5DEV-2425
Changes proposed in this pull request:
a. Undecrypted bytes are identified by buffer identity and rejected, and the session is closed. Renegotiation and a client's final commands sent together with its TLS close (FFmpeg's FCUnpublish) still get through. The first version of the guard dropped those final commands; the node test caught it, so it was redone.
b. SSLException now closes the connection, instead of Red5 assuming MINA does it.
c. The decoder consumes its input when the connection is already gone. That stops the loop that tied up the customer's I/O threads for an hour. The loop is proven and the fix verified in a JVM test, but it never reproduced on a node.