Repository navigation
Move Service Controls - #2066
Merged
Merged
Conversation
Contributor
Author
|
@billz do you have a setup handy that could test the openvpn and wireguard new controls? |
Member
|
@Jixabon sure, I can figure out a way to test these services |
Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.12.4 to 6.14.0. - [Release notes](https://github.com/ajv-validator/ajv/releases) - [Commits](ajv-validator/ajv@v6.12.4...v6.14.0) --- updated-dependencies: - dependency-name: ajv dependency-version: 6.14.0 dependency-type: indirect ... Signed-off-by: dependabot[bot]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to move service control buttons up near the service status indicator.
Why?
In a few instances there were issues with the service control buttons not being able to function due to form validation that the button was a part of. Moving the service control buttons outside of the general page forms solves this problem entirely. In addition, consolidating this part of the UI make it more clear as to what can be done with the page form (eg save setting) and where to go to manage the service.
Controls moved
ToDos