Repository navigation
Make sure checkModuleRequiresAttention() is called for all channels expect when version is unknown or store is up-to-date - #1769
Merged
ga-devfront merged 1 commit intoApr 3, 2026
Conversation
…xpect when version is unknown or store is up-to-date
|
ga-devfront
approved these changes
Apr 2, 2026
ingridusta
approved these changes
Apr 3, 2026
ingridusta
left a comment
There was a problem hiding this comment.
Hi @Quetzacoalt91,
Thanks for your fix, it works as expected :
php bin/console update:check-requirements --channel=online_recommended admin-dev
php bin/console update:check-requirements --channel=local --zip=910prod.zip --xml=910prod.xml admin-devto published version
php bin/console update:check-requirements --channel=local --zip=920.zip --xml=9920.xml admin-devto unpublished version
- No regression detected with command
update:check-requirementsto any--channeland when the targeted version is not published yet we have this message :
- PS version is up to date :
It's QA approved ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Uh oh!
There was an error while loading. Please reload this page.