Skip to content

Make sure checkModuleRequiresAttention() is called for all channels expect when version is unknown or store is up-to-date - #1769

Merged
ga-devfront merged 1 commit into
PrestaShop:7.6.xfrom
Quetzacoalt91:fix-call-conditions-to-checkModuleRequiresAttention
Apr 3, 2026
Merged

ga-devfront merged 1 commit into
PrestaShop:7.6.xfrom
Quetzacoalt91:fix-call-conditions-to-checkModuleRequiresAttention

Conversation

@Quetzacoalt91

@Quetzacoalt91 Quetzacoalt91 commented Apr 2, 2026 •

Copy link
Copy Markdown
Member
Questions Answers
Description? Fix a bug that doesn't check module required attention if we are on local channel
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? N/A
Sponsor company @PrestaShopCorp
How to test?
  • Using a local update must check the modules compatibility, UNLESS the release is not public yet
  • If the shop is up to date, the command must not fail but show instead there is nothing to do.

…xpect when version is unknown or store is up-to-date
@Quetzacoalt91 Quetzacoalt91 self-assigned this Apr 2, 2026
@Quetzacoalt91 Quetzacoalt91 added the bug Type: Bug fix label Apr 2, 2026
@github-project-automation github-project-automation Bot moved this to Ready for review in PR Dashboard Apr 2, 2026
@sonarqubecloud

sonarqubecloud Bot commented Apr 2, 2026

Copy link
Copy Markdown

@Quetzacoalt91 Quetzacoalt91 added this to the 7.6.2 milestone Apr 2, 2026
@ps-jarvis ps-jarvis added the Waiting for QA Status: Action required, Waiting for test feedback label Apr 2, 2026
@ps-jarvis ps-jarvis moved this from Ready for review to To be tested in PR Dashboard Apr 2, 2026
@ingridusta ingridusta self-assigned this Apr 3, 2026

@ingridusta ingridusta left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Quetzacoalt91,

Thanks for your fix, it works as expected :

  • php bin/console update:check-requirements --channel=online_recommended admin-dev
Image
  • php bin/console update:check-requirements --channel=local --zip=910prod.zip --xml=910prod.xml admin-dev to published version
Image
  • php bin/console update:check-requirements --channel=local --zip=920.zip --xml=9920.xml admin-dev to unpublished version
Image
  • No regression detected with command update:check-requirements to any --channel and when the targeted version is not published yet we have this message :
Image
  • PS version is up to date :
Image

It's QA approved ✅

@ingridusta ingridusta added QA ✔️ Status: Check done, Code approved and removed Waiting for QA Status: Action required, Waiting for test feedback labels Apr 3, 2026
@ga-devfront
ga-devfront merged commit 7fc7c1b into PrestaShop:7.6.x Apr 3, 2026
64 checks passed
@github-project-automation github-project-automation Bot moved this from To be tested to Merged in PR Dashboard Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Type: Bug fix QA ✔️ Status: Check done, Code approved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants