Repository navigation
AbstractArrayDeclarationSniff::getActualArrayKey(): catch catchable exceptions - #775
Merged
jrfnl merged 1 commit intoJul 27, 2026
Conversation
…xceptions As things were, if the `eval()`-ed code would result in a catchable exception, PHPCS would crash and exit. This commit hardens the method by adding extra defensive coding to prevent this. Includes tests.
Member
Author
|
Merging as the markdown lint failure is nonsense. |
jrfnl
deleted the
feature/abstractarraydeclarationsniff-getactualarraykey-improve-exception-handling
branch
July 27, 2026 09:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As things were, if the
eval()-ed code would result in a catchable exception, PHPCS would crash and exit.This commit hardens the method by adding extra defensive coding to prevent this.
Includes tests.