Skip to content

Implement asynchronous support in ODataJsonReaderCoreUtils - #2255

Merged
gathogojr merged 1 commit into
OData:masterfrom
gathogojr:feature/odatajsonreadercoreutils-async
Nov 22, 2021
Merged

gathogojr merged 1 commit into
OData:masterfrom
gathogojr:feature/odatajsonreadercoreutils-async

Conversation

@gathogojr

@gathogojr gathogojr commented Nov 18, 2021 •

Copy link
Copy Markdown
Contributor

Issues

This pull request partially fulfills #2019.

Description

Implement asynchronous support in ODataJsonReaderCoreUtils

Checklist (Uncheck if it is not completed)

  • Test cases added
  • Build and test with one-click build and test script passed

Additional work necessary

If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.

Comment thread src/Microsoft.OData.Core/Json/JsonReaderExtensions.cs Outdated
Comment thread src/Microsoft.OData.Core/Json/JsonReaderExtensions.cs
Comment thread src/Microsoft.OData.Core/Json/JsonReaderExtensions.cs Outdated
Comment thread src/Microsoft.OData.Core/Json/JsonReaderExtensions.cs
Comment thread src/Microsoft.OData.Core/Json/JsonReaderExtensions.cs Outdated
Comment thread src/Microsoft.OData.Core/Json/JsonReaderExtensions.cs
Comment thread src/Microsoft.OData.Core/Json/ODataJsonReaderCoreUtils.cs Outdated
Comment thread src/Microsoft.OData.Core/Json/ODataJsonReaderCoreUtils.cs Outdated
@gathogojr
gathogojr force-pushed the feature/odatajsonreadercoreutils-async branch from b4a83e9 to 633ce2d Compare November 19, 2021 05:26
@gathogojr

Copy link
Copy Markdown
Contributor Author

@odero For the comments relevant to JsonReaderExtensions class, I'll consider them in the dependent PR #2248.

@gathogojr
gathogojr force-pushed the feature/odatajsonreadercoreutils-async branch from 633ce2d to d19bf0a Compare November 19, 2021 07:40
Comment thread src/Microsoft.OData.Core/Json/ODataJsonReaderCoreUtils.cs Outdated
Comment thread src/Microsoft.OData.Core/Json/ODataJsonReaderCoreUtils.cs Outdated
@gathogojr
gathogojr force-pushed the feature/odatajsonreadercoreutils-async branch from d19bf0a to f673235 Compare November 22, 2021 14:38
@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 305 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Large
Size       : +300 -5
Percentile : 70.5%

Total files changed: 2

Change summary by file extension:
.cs : +300 -5

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@gathogojr
gathogojr merged commit eaef179 into OData:master Nov 22, 2021
@gathogojr
gathogojr deleted the feature/odatajsonreadercoreutils-async branch November 22, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants