Repository navigation
Perf Fix for swallowed exception in AppendKeySegment - #2024
Merged
Merged
Conversation
mikepizzo
reviewed
Mar 24, 2021
| } | ||
| } | ||
| } | ||
| catch (ODataException) |
Contributor
There was a problem hiding this comment.
why still catch the exception if we just re-throw it? should just be able to remove the try/catch #Resolved
mikepizzo
reviewed
Mar 24, 2021
| } | ||
|
|
||
| return properties; | ||
| return properties.ToArray(); |
Contributor
Contributor
Author
There was a problem hiding this comment.
In other methods the returned key property is accessed, and passed down to other methods as array (in most cases) . Thats the reason we returned it as array
In reply to: 600680945 [](ancestors = 600680945)
Sreejithpin
changed the title
Sreejithpin
marked this pull request as ready for review
April 5, 2021 19:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Firing performance issue in case of odata exception being swallowed. Trying to get keys in case we intend to follow without any exception
This pull request fixes issue #xxx.
Description
Briefly describe the changes of this pull request.
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.