Repository navigation
Bugfix/headers should be case insensitive - #1886
Merged
mikepizzo merged 8 commits intoSep 22, 2020
Merged
Conversation
marabooy
requested review from
ElizabethOkerio,
KenitoInc,
Sreejithpin,
g2mula,
gathogojr,
habbes,
mikepizzo,
odero and
xuzhg
September 17, 2020 20:00
paulodero
requested changes
Sep 22, 2020
paulodero
left a comment
paulodero
left a comment
Contributor
There was a problem hiding this comment.
I noticed the rolling pipeline was cancelled before execution was complete. Could you run the build pipeline to the end to ensure all the tests are executed before opening this PR for review.
paulodero
requested changes
Sep 22, 2020
marabooy
force-pushed
the
bugfix/headers-should-be-case-insensitive
branch
from
September 22, 2020 09:17
39f8a70 to
32eed97
Compare
marabooy
added
the
Ready for review
Contributor
|
Build is passing and it looks like all comments have been addressed. @paulodero please re-review and sign-off if you are satisfied with the resolutions. |
gathogojr
reviewed
Sep 22, 2020
gathogojr
approved these changes
Sep 22, 2020
Co-authored-by: John Gathogo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes issue #1882 .
Description
Briefly describe the changes of this pull request.
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.