Skip to content

Fix ODL warnings - #1823

Closed
KenitoInc wants to merge 9 commits into
OData:masterfrom
KenitoInc:fix/ODLWarnings
Closed

KenitoInc wants to merge 9 commits into
OData:masterfrom
KenitoInc:fix/ODLWarnings

Conversation

@KenitoInc

Copy link
Copy Markdown
Contributor

Issues

This pull request fixes issue #1709 #1710.

Description

Fix the warnings below based on FxCop Analyzers rules
Fix CS1587
Fix CS1574
Fix CS0419
Fix CA2007
Fix xUnit2013
Fix xUnit2000
Fix CA1018
Fix CS1584
Fix CA1018

Checklist (Uncheck if it is not completed)

  • Test cases added
  • Build and test with one-click build and test script passed

Additional work necessary

If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.

@KenitoInc KenitoInc added the Ready for review Use this label if a pull request is ready to be reviewed label Jun 24, 2020
xuzhg pushed a commit that referenced this pull request Jun 24, 2020
@xuzhg

xuzhg commented Jun 24, 2020

Copy link
Copy Markdown
Contributor

Merged. Thanks.

@xuzhg xuzhg closed this Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready for review Use this label if a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants