Repository navigation
Fix decoding single quote within double-quoted string in action/function parameter alias - #1783
Merged
gathogojr merged 4 commits intoMay 21, 2020
Conversation
gathogojr
requested review from
ElizabethOkerio,
KenitoInc,
g2mula,
habbes,
marabooy,
mikepizzo,
odero,
paulodero,
wachugamaina,
wandeg and
xuzhg
May 19, 2020 08:15
odero
approved these changes
May 20, 2020
| } | ||
|
|
||
| [Fact] | ||
| public void ParsePath_AliasInUnboundFunction_SingleAndEscapedDoubleQuotesWithinDoubleQuotedString() |
There was a problem hiding this comment.
Seems to me like these tests could be DRY'd since the logic is the same
gathogojr
force-pushed
the
fix/2051-decoding-single-quote-within-double-quoted-string
branch
from
May 20, 2020 18:47
f618188 to
6550bea
Compare
gathogojr
added
the
Ready for review
gathogojr
force-pushed
the
fix/2051-decoding-single-quote-within-double-quoted-string
branch
from
May 21, 2020 06:09
6550bea to
46eb5cf
Compare
gathogojr
deleted the
fix/2051-decoding-single-quote-within-double-quoted-string
branch
May 21, 2020 06:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes issue reported on OData Web API project OData/WebApi#2051.
Description
Fixes decoding of single quote within a double-quoted string in action/function parameter alias, e.g.
http://ServiceRoot/UnboundFunction(param=@p)?@p={"@odata.type":"%23NS.Film","Id":1,"Title":"The Ogre's Lair"}Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.