Repository navigation
Add support for Json Batch Requests in Odata Client - #1749
Merged
Merged
Conversation
KenitoInc
marked this pull request as ready for review
April 24, 2020 11:51
KenitoInc
force-pushed
the
feature/json-batch-requests
branch
from
April 24, 2020 12:00
41168a3 to
9611731
Compare
KenitoInc
requested review from
ElizabethOkerio,
KanishManuja-MS,
gathogojr,
habbes,
marabooy,
mikepizzo,
odero and
paulodero
and removed request for
odero
April 24, 2020 12:01
odero
added
the
Ready for review
mikepizzo
reviewed
May 6, 2020
mikepizzo
reviewed
May 6, 2020
| if (!this.useJsonBatch) | ||
| { | ||
| Error.ThrowBatchExpectedResponse(InternalError.UnexpectedBatchState); | ||
| } |
Contributor
There was a problem hiding this comment.
Really? This seems like a bug in the ODataJsonLightBatchReader -- your state shouldn't depend on the format.
Contributor
Author
There was a problem hiding this comment.
@mikepizzo Definitely a bug in ODataJsonLightBatchReader
odero
requested changes
May 6, 2020
KenitoInc
force-pushed
the
feature/json-batch-requests
branch
from
May 11, 2020 11:21
b430901 to
a8642a4
Compare
paulodero
reviewed
May 19, 2020
gathogojr
reviewed
May 19, 2020
gathogojr
approved these changes
May 19, 2020
gathogojr
left a comment
gathogojr
left a comment
Contributor
There was a problem hiding this comment.
@KenitoInc Left one comment, otherwise LGTM
KenitoInc
force-pushed
the
feature/json-batch-requests
branch
from
May 19, 2020 10:12
999e6b9 to
ff754ff
Compare
odero
approved these changes
May 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently Odata Client only supports multipart/mixed batch requests while ODL has support for both json batch requests and multipart/mixed batch requests. We are adding support for OData Json Batch Requests in OData Client.
We are adding a new
SaveChangesOptionflag namedUseJsonBatch. When you add the flag in batch requests when calling SaveChangesAsync, the request and response will have Content-Type asapplication/jsonChecklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.