Repository navigation
Support for abstract complex types with no properties - #1731
Merged
KanishManuja-MS merged 1 commit intoMay 19, 2020
Conversation
ElizabethOkerio
force-pushed
the
fix/1581-support-for-abstract-complex-types-with-no-properties
branch
from
April 8, 2020 06:17
ee08abc to
6ccdf35
Compare
ElizabethOkerio
added
the
Ready for review
ElizabethOkerio
force-pushed
the
fix/1581-support-for-abstract-complex-types-with-no-properties
branch
from
April 9, 2020 07:34
6ccdf35 to
edd4294
Compare
xuzhg
approved these changes
Apr 9, 2020
Contributor
|
@ElizabethOkerio It's better to have a test case to cover the changes. |
odero
changed the title
odero
reviewed
Apr 15, 2020
ElizabethOkerio
force-pushed
the
fix/1581-support-for-abstract-complex-types-with-no-properties
branch
from
April 15, 2020 07:05
edd4294 to
e072628
Compare
odero
reviewed
Apr 16, 2020
odero
approved these changes
Apr 16, 2020
marabooy
approved these changes
Apr 16, 2020
ElizabethOkerio
force-pushed
the
fix/1581-support-for-abstract-complex-types-with-no-properties
branch
from
April 20, 2020 06:53
ba8b2e8 to
308980b
Compare
ElizabethOkerio
force-pushed
the
fix/1581-support-for-abstract-complex-types-with-no-properties
branch
2 times, most recently
from
May 6, 2020 06:50
8836090 to
ac7a5ae
Compare
ElizabethOkerio
force-pushed
the
fix/1581-support-for-abstract-complex-types-with-no-properties
branch
from
May 13, 2020 09:26
98e3296 to
89b7412
Compare
KanishManuja-MS
self-requested a review
May 18, 2020 17:29
KanishManuja-MS
approved these changes
May 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes issue #1581.
Description
Since Web API OData V5.5-beta, it is allowed to:
But in this case, when you define an abstract complex type without any properties an exception is thrown.
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.