Repository navigation
Fix a wrong if condition - #1182
Merged
Merged
Conversation
xuzhg
approved these changes
Jun 6, 2018
biaol-odata
reviewed
Jun 6, 2018
| { | ||
|
var clientInstanceAnnotationValue = new Dictionary |
||
| if (instanceAnnotations != null || instanceAnnotations.Count > 0) | ||
| if (instanceAnnotations != null && instanceAnnotations.Count > 0) |
Contributor
There was a problem hiding this comment.
Should we just remove the "&& instanceAnnotations.Count > 0" check completely?
Contributor
There was a problem hiding this comment.
Yes; we should be able to get rid of the instanceAnnotations.Count check all together.
biaol-odata
approved these changes
Jun 6, 2018
Contributor
|
@mrdotmoon Have you got a chance to look at the comment above and see whether it makes sense? Thanks. |
Contributor
Author
|
@biaol-odata yeah, it makes sense. Updated, thanks. |
biaol-odata
pushed a commit
to biaol-odata/odata.net
that referenced
this pull request
Jun 26, 2018
* Fix a wrong if condition * Remove count check
biaol-odata
pushed a commit
that referenced
this pull request
Jun 26, 2018
* Fix a wrong if condition * Remove count check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fix a wrong if condition